[
https://issues.apache.org/jira/browse/IMPALA-15347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18118982#comment-18118982
]
ASF subversion and git services commented on IMPALA-15347:
----------------------------------------------------------
Commit b69b3ea7492ac8a8bdfa8431e6f583e0ca86b8f5 in impala's branch
refs/heads/master from Peter Rozsa
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=b69b3ea74 ]
IMPALA-15347: Move static S3 credential handling into S3ConnCredentials
Extracts the --s3a_access_key_cmd / --s3a_secret_key_cmd handling out of
HdfsFsCache into a new S3ConnCredentials class. The flags and the
command execution now live in s3-conn-credentials.{h,cc}; Init() runs
once at daemon startup (after HdfsFsCache::Init()) and stores the result
as a generic fs.s3a.* config map. HdfsFsCache::GetConnection() consumes
that map when building a connection instead of two ad-hoc static strings.
Behaviour is unchanged: setting only one of the two flags is still
ignored (now with a warning), and so is a command that succeeds but
prints nothing, so the keys in the Hadoop client configuration are never
overridden with empty ones. The secret-key error message previously
said "Access Key"; it now says "Secret Key".
This prepares HdfsFsCache for taking per-query vended credentials in the
same map form.
Change-Id: Ie48cbb0c313f32242c4fce6603eab3e54d08cabd
Assisted-by: Claude Fable 5.1 <[email protected]>
Reviewed-on: http://gerrit.cloudera.org:8080/24837
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Move static S3 credential handling into S3ConnCredentials
> ---------------------------------------------------------
>
> Key: IMPALA-15347
> URL: https://issues.apache.org/jira/browse/IMPALA-15347
> Project: IMPALA
> Issue Type: Sub-task
> Components: Backend
> Reporter: Peter Rozsa
> Assignee: Peter Rozsa
> Priority: Major
> Labels: impala-iceberg
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
