[ 
https://issues.apache.org/jira/browse/AMQ-5503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538001#comment-14538001
 ] 

Timothy Bish commented on AMQ-5503:
-----------------------------------

I did a quick review of the patch this morning, it looks ok to me although I 
did see a failure in your test suite:

{noformat}
   FAIL : not successful => 
/tmp/activemq/initscript-testing-4512-timothy/a/b/c/d/.././e//activemq-instance-test3
 bstat |grep TotalConsumerCount
{noformat}

I also observed that the test script leaves a file around after running it 
called "stop.stop" so you should ensure it cleans up fully.  It seemed to not 
want to run again unless this was deleted.  

> Make init script more reliable
> ------------------------------
>
>                 Key: AMQ-5503
>                 URL: https://issues.apache.org/jira/browse/AMQ-5503
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 5.11.1
>         Environment: Unix/Linux
>            Reporter: Marc Schöchlin
>            Assignee: Jean-Baptiste Onofré
>              Labels: documentation, initscript
>
> The Activemq init script received with AMQ-5378 some changes which improve 
> the quality of the init script. This ticket addresses further improvements.
> - Add a shellscript testsuite to ease the verification of the proper function 
> on various unix platforms (Linux, MacOS, ...)
> - Make the shellscript code more reliable
> - Improve usability for administrative users
> Current pull request: https://github.com/apache/activemq/pull/61



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to