[ 
https://issues.apache.org/jira/browse/AMQ-5777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14551149#comment-14551149
 ] 

Christopher L. Shannon commented on AMQ-5777:
---------------------------------------------

As you mentioned, the count needs someway to be tracked across the parseAction 
and parseHeaders method calls from StompCodec to keep a running total.  
However, I like your idea of the use of an AtomicLong so I went ahead and 
updated my pull request with that change.  Currently StompWireFormat still 
creates a new AtomicLong for every unmarshal call, which I left in there for 
thread safety. However, if StompWireFormat will only every unmarshal one 
message at a time I could move that value to the class level and reset it back 
to 0 at the end just like StompCodec does in processCommand.  Let me know what 
you think.

> Implement and test maxFrameSize for STOMP
> -----------------------------------------
>
>                 Key: AMQ-5777
>                 URL: https://issues.apache.org/jira/browse/AMQ-5777
>             Project: ActiveMQ
>          Issue Type: Sub-task
>          Components: Broker
>    Affects Versions: 5.11.1
>            Reporter: Christopher L. Shannon
>            Assignee: Timothy Bish
>
> Implement and test {{maxFameSize}} for STOMP to help prevent DOS attacks.  
> Testing should include TCP, SSL, NIO and NIO+SSL, etc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to