[
https://issues.apache.org/jira/browse/ARTEMIS-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14570624#comment-14570624
]
ASF GitHub Bot commented on ARTEMIS-127:
----------------------------------------
Github user mtaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-108295200
Hi Howard. I realise that @clebertsuconic already mentioned this but it
looks like you are importing a lot of code from ActiveMQ. Reuse of test suites
is probably going to required for more than just OpenWire going forward. It
would be great if you could find a clean solution for this.
We should try to avoid importing code from ActiveMQ into Artemis as it will
just sit there and rot whilst the ActiveMQ code base moves forward. A neater
way to do this would be to import the test module artifact and extend the
relevant pieces. If this is not possible right now it is probably worth
implementing some extension points in the ActiveMQ code base to allow reuse of
their test suites.
A start might be to implement an Artemis broker service as @clebertsuconic
suggested.
Let's have a chat on IRC.
> Adding activemq unit test module to Artemis
> -------------------------------------------
>
> Key: ARTEMIS-127
> URL: https://issues.apache.org/jira/browse/ARTEMIS-127
> Project: ActiveMQ Artemis
> Issue Type: Sub-task
> Components: OpenWire
> Affects Versions: 1.0.0
> Reporter: Howard Gao
> Assignee: Howard Gao
> Fix For: 1.1.0
>
>
> Add a sub module that imports activemq(openwire) unit test suites.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
