[ 
https://issues.apache.org/jira/browse/ARTEMIS-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14581286#comment-14581286
 ] 

ASF GitHub Bot commented on ARTEMIS-135:
----------------------------------------

GitHub user clebertsuconic opened a pull request:

    https://github.com/apache/activemq-artemis/pull/23

    ARTEMIS-135 - Fix on journal load

    https://issues.apache.org/jira/browse/ARTEMIS-135
    
    This is importing a recent fix from the journal on the old version.
    If a crash happened between the create file and the fill of the file the
    file wouldn't be loaded and the server wouldn't start until you removed the 
offending file

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/clebertsuconic/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/23.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23
    
----
commit 72354ee38fab9073ab4750ccd2281ba75bd2ffba
Author: Tomas Hofman <thof...@redhat.com>
Date:   2015-06-11T00:27:55Z

    ARTEMIS-135 - Fix on journal load
    
    https://issues.apache.org/jira/browse/ARTEMIS-135
    
    This is importing a recent fix from the journal on the old version.
    If a crash happened between the create file and the fill of the file the
    file wouldn't be loaded and the server wouldn't start until you removed the 
offending file

----


> Server won’t start if one of the journal files is truncated for any reason
> --------------------------------------------------------------------------
>
>                 Key: ARTEMIS-135
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-135
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 1.0.0
>            Reporter: Matthew Robson
>            Priority: Blocker
>             Fix For: 1.0.1
>
>
> Server won’t start if one of the journal files is truncated for any reason.  
> In this case, there was a 0 byte journal file left behind.  This will happen 
> if any file is less then the header-size.
> 09:14:56,186 SEVERE [org.hornetq.core.server.impl.HornetQServerImpl] (MSC 
> service thread 1-3) Failure in initialisation: 
> java.nio.BufferUnderflowException
>       at java.nio.Buffer.nextGetIndex(Buffer.java:498) [rt.jar:1.7.0_71]
>       at java.nio.HeapByteBuffer.getInt(HeapByteBuffer.java:355) 
> [rt.jar:1.7.0_71]
>       at 
> org.hornetq.core.journal.impl.JournalImpl.readFileHeader(JournalImpl.java:2807)
>  [hornetq-core-2.2.24.BZ928936.jar:2.2.24.BZ928936 (HQ_2_2_24_BZ928936, 122)]
>       at 
> org.hornetq.core.journal.impl.JournalImpl.orderFiles(JournalImpl.java:399) 
> [hornetq-core-2.2.24.BZ928936.jar:2.2.24.BZ928936 (HQ_2_2_24_BZ928936, 122)]
>       at 
> org.hornetq.core.journal.impl.JournalImpl.load(JournalImpl.java:1884) 
> [hornetq-core-2.2.24.BZ928936.jar:2.2.24.BZ928936 (HQ_2_2_24_BZ928936, 122)]
>       at 
> org.hornetq.core.journal.impl.JournalImpl.load(JournalImpl.java:1496) 
> [hornetq-core-2.2.24.BZ928936.jar:2.2.24.BZ928936 (HQ_2_2_24_BZ928936, 122)]
>       at 
> org.hornetq.core.journal.impl.JournalImpl.load(JournalImpl.java:1480) 
> [hornetq-core-2.2.24.BZ928936.jar:2.2.24.BZ928936 (HQ_2_2_24_BZ928936, 122)]
>       at 
> org.hornetq.core.persistence.impl.journal.JournalStorageManager.loadMessageJournal(JournalStorageManager.java:936)
>  [hornetq-core-2.2.24.BZ928936.jar:2.2.24.BZ928936 (HQ_2_2_24_BZ928936, 122)]
>       at 
> org.hornetq.core.server.impl.HornetQServerImpl.loadJournals(HornetQServerImpl.java:1731)
>  [hornetq-core-2.2.24.BZ928936.jar:2.2.24.BZ928936 (HQ_2_2_24_BZ928936, 122)]
>       at 
> org.hornetq.core.server.impl.HornetQServerImpl.initialisePart2(HornetQServerImpl.java:1547)
>  [hornetq-core-2.2.24.BZ928936.jar:2.2.24.BZ928936 (HQ_2_2_24_BZ928936, 122)]
>       at 
> org.hornetq.core.server.impl.HornetQServerImpl.access$1200(HornetQServerImpl.java:141)
>  [hornetq-core-2.2.24.BZ928936.jar:2.2.24.BZ928936 (HQ_2_2_24_BZ928936, 122)]
>       at 
> org.hornetq.core.server.impl.HornetQServerImpl$SharedStoreLiveActivation.run(HornetQServerImpl.java:2060)
>  [hornetq-core-2.2.24.BZ928936.jar:2.2.24.BZ928936 (HQ_2_2_24_BZ928936, 122)]
>       at 
> org.hornetq.core.server.impl.HornetQServerImpl.start(HornetQServerImpl.java:369)
>  [hornetq-core-2.2.24.BZ928936.jar:2.2.24.BZ928936 (HQ_2_2_24_BZ928936, 122)]
>       at 
> org.hornetq.jms.server.impl.JMSServerManagerImpl.start(JMSServerManagerImpl.java:282)
>  [hornetq-jms-2.2.24.BZ928936.jar:2.2.24.BZ928936 (HQ_2_2_24_BZ928936, 122)]
>       at org.jboss.as.messaging.jms.JMSService.start(JMSService.java:73) 
> [jboss-as-messaging-7.1.3.Final-redhat-4.jar:7.1.3.Final-redhat-4]
>       at 
> org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1811)
>  [jboss-msc-1.0.2.GA-redhat-2.jar:1.0.2.GA-redhat-2]
>       at 
> org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1746)
>  [jboss-msc-1.0.2.GA-redhat-2.jar:1.0.2.GA-redhat-2]
>       at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
>  [rt.jar:1.7.0_71]
>       at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
>  [rt.jar:1.7.0_71]
>       at java.lang.Thread.run(Thread.java:745) [rt.jar:1.7.0_71]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to