[
https://issues.apache.org/jira/browse/AMQ-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14600217#comment-14600217
]
ASF GitHub Bot commented on AMQ-5859:
-------------------------------------
GitHub user benbenw opened a pull request:
https://github.com/apache/activemq/pull/122
AMQ-5859 JmsConnector Reconnection logic seems wrong
https://issues.apache.org/jira/browse/AMQ-5859
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benbenw/activemq AMQ-5859
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq/pull/122.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #122
----
commit 1feaf75dd6e42d256e92b5432abe2219d4c65e40
Author: benbenw <benoit.wi...@gmail.com>
Date: 2015-06-24T21:45:53Z
AMQ-5859 Reconnection attempt logic seems wrong in
JmsConnector#doInitializeConnection
----
> Reconnection attempt logic seems wrong in JmsConnector#doInitializeConnection
> -----------------------------------------------------------------------------
>
> Key: AMQ-5859
> URL: https://issues.apache.org/jira/browse/AMQ-5859
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.10.2, 5.11.1
> Reporter: Benoit Wiart
> Priority: Critical
> Attachments:
> 0001-AMQ-5859-Reconnection-attempt-logic-seems-wrong-in-J.patch
>
>
> the reconnection attempts logic based on the reconnection policy seems wrong.
> In JmsConnector#doInitializeConnection the loop trying to reconnect to the
> foreign broker only execute once due to the erroneous test in the while
> {code}
> while (maxRetries < ++attempt && !connectionSerivce.isTerminating());
> {code}
> should be
> {code}
> while (maxRetries > ++attempt && !connectionSerivce.isTerminating());
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
