[
https://issues.apache.org/jira/browse/ARTEMIS-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14605155#comment-14605155
]
ASF GitHub Bot commented on ARTEMIS-146:
----------------------------------------
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/55#issuecomment-116444946
First, you are changing semantics of a production of a production server
because the test is not adapting... it's wrong.
Second, when a JMS Object is created it needs to also create JMS objects
for the JMS Created Queue, that should happen through the JMS Manager. You are
cutting this directly into a core-queue, it's also wrong.
Why can't you fix the test and add the JMS Manager?
> Fix Queue auto-creation
> -----------------------
>
> Key: ARTEMIS-146
> URL: https://issues.apache.org/jira/browse/ARTEMIS-146
> Project: ActiveMQ Artemis
> Issue Type: Sub-task
> Components: OpenWire
> Affects Versions: 1.0.0
> Reporter: Howard Gao
> Assignee: Howard Gao
> Fix For: 1.1.0
>
>
> Currently we use JMSQueueCreator to create queues automatically, however
> openwire shouldn't depends on JMS stuff. If jms component is not deployed the
> creator is null.
> Solution: use its own queue creation method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
