[ 
https://issues.apache.org/jira/browse/AMQ-5876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Tully resolved AMQ-5876.
-----------------------------
    Resolution: Fixed
      Assignee: Gary Tully

prop file loaded once and reloaded if reload=true after a modification.
dn lookup done on map - the inverted prop file. dn must be unique or non-unique 
values will overwrite the map entries keyed by dn.
http://git-wip-us.apache.org/repos/asf/activemq/commit/59cd0189

> improve performance of TextFileCertificateLoginModule when many entries are 
> in the "textfiledn.user " file
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: AMQ-5876
>                 URL: https://issues.apache.org/jira/browse/AMQ-5876
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: jaas, security
>    Affects Versions: 5.11.1
>            Reporter: Gary Tully
>            Assignee: Gary Tully
>              Labels: jaas
>             Fix For: 5.12.0
>
>
> With a large number of entries ( 200,000 ) in the 
> "org.apache.activemq.jaas.textfiledn.user" file the performance seemed to 
> degrade. 
> To demonstrate the performance difference;
> {code}
> 1) for 100 entries and calling initialize,login(),commit 10 times - Time 
> taken is 73 miliseconds
> 2) for 200,000 entries and calling initialize,login(),commit 10 times - Time 
> taken is  5020 miliseconds
> {code}
> Suggested improvements:
> - avoid loading the  org.apache.activemq.jaas.textfiledn.user file each time 
> - in PropertiesLoginModule.java, the file is only read when it changes, using 
> the file modification time.
> - avoid iterating through the Properties object, using a Map instead to 
> retrieve the userName



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to