[
https://issues.apache.org/jira/browse/AMQ-5890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629608#comment-14629608
]
ASF subversion and git services commented on AMQ-5890:
------------------------------------------------------
Commit 0cfd22591260540301b18a893cd229c59e43dcf6 in activemq's branch
refs/heads/master from Robert Gemmell
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=0cfd225 ]
AMQ-5890: prevent NPE if Modified disposition is applied without the
delivery-failed flag set, add some general tests of Modified handling
https://issues.apache.org/jira/browse/AMQ-5890
> AMQP: possible NPE when handling disposition with Modified state
> ----------------------------------------------------------------
>
> Key: AMQ-5890
> URL: https://issues.apache.org/jira/browse/AMQ-5890
> Project: ActiveMQ
> Issue Type: Bug
> Components: AMQP
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 5.12.0
>
>
> If a consumer sends a disposition with Modified state in which the
> 'deliveryFailed' field is not populated, the broker will NPE. This is because
> the relevant value is a Boolean object rather than boolean primitive. That
> appears to be because there is actually no default value specified for the
> field in the specification, and it is defined only to be set when delivery
> actually failed (values that are not set are encoded nulls in the AMQP frame).
> The implementation needs updated to handle this value being null, but will be
> left permissive of it being set false.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
