[
https://issues.apache.org/jira/browse/ARTEMIS-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709582#comment-14709582
]
ASF GitHub Bot commented on ARTEMIS-208:
----------------------------------------
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/132#issuecomment-134293839
This fix will only work on tests....
on a default server, the acceptor will be at 0.0.0.0, and you will be
sending tcp://0.0.0.0:port to the client.
It's also wrong to the fact that the same protocolManager will server
multiple acceptors in case you have multiple ports configured. on that case you
will be sending the BrokerInfo for a different port or IP.
Do you have the IP the user used to connect anywhere on the connection? So,
you would have to create a brokerInfo per request.. instead caching a single
one...
for that reason this fix is not valid!
> Fix BrokerInfo Issue
> --------------------
>
> Key: ARTEMIS-208
> URL: https://issues.apache.org/jira/browse/ARTEMIS-208
> Project: ActiveMQ Artemis
> Issue Type: Sub-task
> Components: OpenWire
> Affects Versions: 1.0.0
> Reporter: Howard Gao
> Assignee: Howard Gao
> Fix For: 1.1.0
>
>
> When a client opens a connection to broker, the broker should send back a
> BrokerInfo command.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
