[
https://issues.apache.org/jira/browse/ARTEMIS-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14720324#comment-14720324
]
ASF GitHub Bot commented on ARTEMIS-191:
----------------------------------------
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/142#issuecomment-135845502
@howardgao I confused the class with AMQDestination under amq on the
protocolManager, that's not used anywhere.
I see that this is about temp destinations... although I would prefer that
code (for deletion) out of the ProtocolManager, since the ProtocolManager is
doing a lot more work than what is supposed to be doing...
I will merge your commit, although I'm looking to simplify some of these
function after we release 1.2.
> Refactor RemoveDestinationTest
> ------------------------------
>
> Key: ARTEMIS-191
> URL: https://issues.apache.org/jira/browse/ARTEMIS-191
> Project: ActiveMQ Artemis
> Issue Type: Sub-task
> Components: OpenWire
> Affects Versions: 1.0.0
> Reporter: Howard Gao
> Assignee: Howard Gao
> Fix For: 1.3.0
>
>
> The RemoveDestinationTest is using a vm specific url to creat brokers in
> order to test destination removal functionality. Which causes failure because
> of its using of internal mechanism to find and launch a broker.
> It is very possible to use a 'standard' way to launch a tcp broker to do the
> same test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
