[ 
https://issues.apache.org/jira/browse/AMQ-5942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901058#comment-14901058
 ] 

Christopher L. Shannon commented on AMQ-5942:
---------------------------------------------

Yeah I figured the LRU cache was chosen for a reason which was my initial 
hesitation to change it.  So do you think this is something worth changing or 
do you just want to leave it as is and document it?  I suppose the default size 
of 1024 could also be increased as another option but not sure what a good 
default size would be.

> CachedMessageGroupMapFactory fails with large key sets
> ------------------------------------------------------
>
>                 Key: AMQ-5942
>                 URL: https://issues.apache.org/jira/browse/AMQ-5942
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 5.11.1
>            Reporter: Ben O'Day
>         Attachments: MessageGroupFactoryRouteTest.java
>
>
> the current default factory is the CachedMessageGroupMapFactory which uses an 
> LRUMap with a maxSize of 1024 keys.  If you use this with more than 1024 keys 
> and fail to explicitly increase the maxSize, then the message groups fails to 
> ensure ordering by group, same thread processing by group and overlapping 
> execution.  
> I have reproduced this behavior in the attached unit test (using Camel routes 
> as consumers)...if you switch to the SimpleMessageGroupMapFactory or increase 
> the max size of the cache above the number of keys...the issues go away
> two suggestions
> -throw an error when the maxSize is exceeded if using the 
> CachedMessageGroupMapFactory
> -make the SimpleMessageGroupMapFactory the default (unlimited)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to