[
https://issues.apache.org/jira/browse/ARTEMIS-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14908511#comment-14908511
]
ASF GitHub Bot commented on ARTEMIS-228:
----------------------------------------
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/176#issuecomment-143320708
I made one small *optional* modification to the test.. during the merge of
this
> Accept BinaryWebSocketFrame in STOMP WebSocketServerHandler
> -----------------------------------------------------------
>
> Key: ARTEMIS-228
> URL: https://issues.apache.org/jira/browse/ARTEMIS-228
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Julian Scheid
> Priority: Minor
>
> {{WebSocketServerHandler}} currently only accepts {{TextWebSocketFrame}}, but
> there is no reason why it shouldn't accept {{BinaryWebSocketFrame}} as well,
> especially seeing that STOMP supports binary payloads. Some WebSocket clients
> insist on sending binary packets under certain circumstances, for example
> https://github.com/theturtle32/WebSocket-Node does.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
