[ 
https://issues.apache.org/jira/browse/AMQ-5990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aravind Chennuru updated AMQ-5990:
----------------------------------
    Description: 
initConnectionPool does not allow us to configure the GenericKeyObjectPool.
Suggestion:
PooledConnectionFactory
{code}
private GenericKeyedObjectPoolConfig config;
public void setBasePoolConfig(final GenericKeyedObjectPoolConfig config) {
        this.config = config;
}

public void initConnectionsPool() {
     if (this.connectionsPool == null) {
            this.connectionsPool = new GenericKeyedObjectPool<ConnectionKey, 
ConnectionPool>(blah, config==null?new GenericKeyedObjectPoolConfig():config);
     }
}

protected ConnectionPool createConnectionPool(Connection connection) {
        return new ConnectionPool(connection, config);
    }
{code}
ConnectionPool
{code}
public ConnectionPool(Connection connection) {
      this(connection, new GenericKeyedObjectPoolConfig());
}

public ConnectionPool(Connection connection, GenericKeyedObjectPoolConfig 
config) {
      this.connection = wrap(connection);
      this.sessionPool = new GenericKeyedObjectPool<SessionKey, 
SessionHolder>(blah, config==null?new GenericKeyedObjectPoolConfig():config);
}
{code}


  was:
initConnectionPool does not allow us to configure the GenericKeyObjectPool.
Suggestion:
{code}
private GenericKeyedObjectPoolConfig config;
public void setBasePoolConfig(final GenericKeyedObjectPoolConfig config) {
        this.config = config;
}

public void initConnectionsPool() {
     if (this.connectionsPool == null) {
            this.connectionsPool = new GenericKeyedObjectPool<ConnectionKey, 
ConnectionPool>(blah, config==null?new GenericKeyedObjectPoolConfig():config);
     }
}
{code}


> PooledConnectionFactory does not allow disabling JMX on GenericKeyObjectPool
> ----------------------------------------------------------------------------
>
>                 Key: AMQ-5990
>                 URL: https://issues.apache.org/jira/browse/AMQ-5990
>             Project: ActiveMQ
>          Issue Type: Bug
>            Reporter: Aravind Chennuru
>             Fix For: 5.12.1
>
>
> initConnectionPool does not allow us to configure the GenericKeyObjectPool.
> Suggestion:
> PooledConnectionFactory
> {code}
> private GenericKeyedObjectPoolConfig config;
> public void setBasePoolConfig(final GenericKeyedObjectPoolConfig config) {
>         this.config = config;
> }
> public void initConnectionsPool() {
>      if (this.connectionsPool == null) {
>             this.connectionsPool = new GenericKeyedObjectPool<ConnectionKey, 
> ConnectionPool>(blah, config==null?new GenericKeyedObjectPoolConfig():config);
>      }
> }
> protected ConnectionPool createConnectionPool(Connection connection) {
>         return new ConnectionPool(connection, config);
>     }
> {code}
> ConnectionPool
> {code}
> public ConnectionPool(Connection connection) {
>       this(connection, new GenericKeyedObjectPoolConfig());
> }
> public ConnectionPool(Connection connection, GenericKeyedObjectPoolConfig 
> config) {
>       this.connection = wrap(connection);
>       this.sessionPool = new GenericKeyedObjectPool<SessionKey, 
> SessionHolder>(blah, config==null?new GenericKeyedObjectPoolConfig():config);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to