[
https://issues.apache.org/jira/browse/AMQ-5996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothy Bish resolved AMQ-5996.
-------------------------------
Resolution: Fixed
Changes added, tests still stable so doesn't seem to have broken anything.
> Durable subscription no updated when reactivated sub changes noLocal value
> --------------------------------------------------------------------------
>
> Key: AMQ-5996
> URL: https://issues.apache.org/jira/browse/AMQ-5996
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.10.2, 5.11.2, 5.12.0
> Reporter: Timothy Bish
> Assignee: Timothy Bish
> Fix For: 5.12.1, 5.13.0
>
>
> When a durable subscription that was offline is reactivated and the selector
> or noLocal value is changed the subscription is supposed to be removed and
> re-added as if it was a new subscription. We currently handle the selector
> part to a certain extent but the DurableSubscription instance that backs the
> offline durable sub contains a selectorExpression that is not updated so
> subscription will not apply the new selector value unless the broker was
> restarted before the reactivation.
> We don't as of yet handle the change of noLocal on the subscription due to
> the fact that prior to v5.12.0 the value was not stored in the persistence
> layer. Now that we store the noLocal value we can check that along with the
> selector and update the subscription, which also needs to update the
> selectorExpression as the noLocal value is filtered via its own expression on
> the selector chain.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
