[
https://issues.apache.org/jira/browse/ARTEMIS-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14987235#comment-14987235
]
ASF GitHub Bot commented on ARTEMIS-292:
----------------------------------------
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/229
ARTEMIS-292 - fix isSameHost on TransportConfiguration
Ive renamed the current isSameHost method to isSameparams as thats what it
checked and added a new method for isSameHost that cjecks the appropriate
params for the connector. Ive changed ClientSessionFactoryImp to use this to
correct the behaviour.
https://issues.apache.org/jira/browse/ARTEMIS-292
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andytaylor/activemq-artemis master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/229.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #229
----
commit 3d80133756701fc432fbe4c0a283ca214693e604
Author: Andy Taylor <[email protected]>
Date: 2015-11-03T10:53:07Z
ARTEMIS-292 - fix isSameHost on TransportConfiguration
Ive renamed the current isSameHost method to isSameparams as thats what it
checked and added a new method for isSameHost that cjecks the appropriate
params for the connector. Ive changed ClientSessionFactoryImp to use this to
correct the behaviour.
https://issues.apache.org/jira/browse/ARTEMIS-292
----
> isSameHost doesn't work
> -----------------------
>
> Key: ARTEMIS-292
> URL: https://issues.apache.org/jira/browse/ARTEMIS-292
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 1.1.0
> Reporter: Andy Taylor
> Assignee: Andy Taylor
>
> TransportConfiguration.isSameHost(...) does a comparison on all the params
> which is incorrect for some scenarios. It needs to check the host/port or
> serverID but only be changed for the calls that needs it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
