[
https://issues.apache.org/jira/browse/ARTEMIS-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14989668#comment-14989668
]
ASF GitHub Bot commented on ARTEMIS-297:
----------------------------------------
GitHub user mtaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/234
ARTEMIS-297 Handle Exceptions during server stop
Stopping the server should be able to handle exceptions thrown by
individual components. Before this patch the stop method would throw
any raised exception and exit. This can lead to partial shutdowns of
the server resulting in leaking threads. This patch catches any
component exceptions and logs an appropriate error message, allowing the
server to properly shutdown.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtaylor/activemq-artemis ARTEMIS-297
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/234.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #234
----
commit b965e7ac2ea5b93073bf20f12e1ea9cad20a1666
Author: Martyn Taylor <[email protected]>
Date: 2015-11-04T12:53:39Z
ARTEMIS-297 Handle Exceptions during server stop
Stopping the server should be able to handle exceptions thrown by
individual components. Before this patch the stop method would throw
any raised exception and exit. This can lead to partial shutdowns of
the server resulting in leaking threads. This patch catches any
component exceptions and logs an appropriate error message, allowing the
server to properly shutdown.
----
> Handle exceptions during server stop
> ------------------------------------
>
> Key: ARTEMIS-297
> URL: https://issues.apache.org/jira/browse/ARTEMIS-297
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Martyn Taylor
>
> The server stop method is quite brittle. If any component throws an
> exception during shutdown, the exception is thrown and the method exits.
> Instead the stop method on the server should be able to handle such
> exceptions and continue shutting down all components and eventually stop the
> ExecutorServices. Failure to do so can lead to leaking threads.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
