[
https://issues.apache.org/jira/browse/ARTEMIS-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14989843#comment-14989843
]
ASF GitHub Bot commented on ARTEMIS-298:
----------------------------------------
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/235
ARTEMIS-298 IPv6 escape broken
Previously we were using a long regular expression to detect whether or not
a
given host was IPv6. However, this was brittle and hard to read. Since we
are
already shipping Google Guava in the distribution it made sense to use the
Guava method com.google.common.net.InetAddresses#isInetAddress rather than
the regular expression.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ipv6
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/235.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #235
----
commit 4d54e43ddcf3055ea9e8f80469c27b16411b6972
Author: jbertram <[email protected]>
Date: 2015-11-03T22:29:27Z
ARTEMIS-298 IPv6 escape broken
Previously we were using a long regular expression to detect whether or not
a
given host was IPv6. However, this was brittle and hard to read. Since we
are
already shipping Google Guava in the distribution it made sense to use the
Guava method com.google.common.net.InetAddresses#isInetAddress rather than
the regular expression.
----
> IPv6 escape doesn't always work
> -------------------------------
>
> Key: ARTEMIS-298
> URL: https://issues.apache.org/jira/browse/ARTEMIS-298
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 1.1.0
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Fix For: 1.1.1
>
>
> Currently a valid IPv6 address like "2620:db8:1:2::1%em1" will not be
> properly escaped with surrounding square brackets (i.e. "[" and "]") which
> causes URI parsing to fail.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
