[
https://issues.apache.org/jira/browse/AMQ-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14991226#comment-14991226
]
Lionel Cons commented on AMQ-6034:
----------------------------------
Tim, I ran into this code because I was looking at the examples shipped with
ActiveMQ
({{assembly/src/release/examples/openwire/swissarmy/src/StompExample.java}}).
Outside of ActiveMQ, STOMP support in Java is quite weak. Looking at
https://stomp.github.io/implementations.html#STOMP_Clients, there are only two
Java libraries listed and both seem to be dead, with no updates in the last two
years.
ActiveMQ has good STOMP support internally but does not directly support STOMP
for client connections. As a proof, the {{activemq-client.jar}} does not
contain the STOMP transport.
Is it something that could change?
If indeed STOMP is fully supported in {{activemq-client.jar}} then I would be
happy to contribute and improve the classes under
{{org/apache/activemq/transport/stomp}}.
> The StompConnection class contains incorrect STOMP code
> -------------------------------------------------------
>
> Key: AMQ-6034
> URL: https://issues.apache.org/jira/browse/AMQ-6034
> Project: ActiveMQ
> Issue Type: Bug
> Components: stomp
> Reporter: Lionel Cons
>
> The org.apache.activemq.transport.stomp.StompConnection class contains
> incorrect code related to STOMP frame handling.
> On the receiving side, receive() uses StompWireFormat which is correct.
> However, the class also contains receiveFrame() which is not correct.
> On the sending side, most related methods use the StompFrame.format() method
> which is not correct, StompWireFormat.marshal() should be used instead.
> So, StompWireFormat should be used in all the marshal/unmarshal operations
> and equivalent code should be removed from the related classes like
> StompConnection.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
