[
https://issues.apache.org/jira/browse/AMQ-6042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothy Bish resolved AMQ-6042.
-------------------------------
Resolution: Fixed
Fix Version/s: 5.13.0
Fix and test added with thanks.
> In ActiveMQMessageConsumer, always set rollback cause
> -----------------------------------------------------
>
> Key: AMQ-6042
> URL: https://issues.apache.org/jira/browse/AMQ-6042
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Reporter: Martin Lichtin
> Fix For: 5.13.0
>
> Attachments: MessageListenerRedeliveryTest.java
>
>
> In ActiveMQMessageConsumer, currently the rollback cause is only set for the
> case auto- or individual-acks. However, it should also be set for the other
> cases, so that in the rollback() method it can be picked up when creating the
> poison ack.
> {code}
> if (isAutoAcknowledgeBatch() || isAutoAcknowledgeEach() ||
> session.isIndividualAcknowledge()) {
> // schedual redelivery and possible dlq processing
> md.setRollbackCause(e);
> rollback();
> } else {
> // Transacted or Client ack: Deliver the next message.
> afterMessageIsConsumed(md, false);
> }
> {code}
> I'd suggest to move md.setRollbackCause(e); to before the if().
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
