[
https://issues.apache.org/jira/browse/ARTEMIS-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116215#comment-15116215
]
ASF GitHub Bot commented on ARTEMIS-358:
----------------------------------------
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/346
ARTEMIS-358 topic mistakenly removed with sub
The problem here is that the management notification listener was mistakenly
removing the topic itself instead of just the non-durable subscription. In
general I can't see why StompProtocolManager even needs to keep track of the
destinations when the broker already does that. As far as I can tell it is
redundant and it's clearly error-prone. Therefore I'm removing the
destination
tracking from StompProtocolManager altogether.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-358
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/346.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #346
----
commit 960e29afadcd3b5848a95406ad14d48099fb6c3c
Author: jbertram <jbert...@apache.org>
Date: 2016-01-25T22:36:02Z
ARTEMIS-358 topic mistakenly removed with sub
The problem here is that the management notification listener was mistakenly
removing the topic itself instead of just the non-durable subscription. In
general I can't see why StompProtocolManager even needs to keep track of the
destinations when the broker already does that. As far as I can tell it is
redundant and it's clearly error-prone. Therefore I'm removing the
destination
tracking from StompProtocolManager altogether.
----
> Topic disappears when STOMP subscriber client disconnects without unsubscribe
> -----------------------------------------------------------------------------
>
> Key: ARTEMIS-358
> URL: https://issues.apache.org/jira/browse/ARTEMIS-358
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Stomp
> Affects Versions: 1.2.0, 1.3.0
> Reporter: Ville Skyttä
> Assignee: Justin Bertram
>
> When a STOMP client which has a subscription to a topic disconnects without
> unsubscribing first, the topic seems to disappear.
> Reproducer:
> # configure a server with a topic (e.g. jms.topic.testtopic) and start it
> # STOMP: connect to the server
> # STOMP: subscribe to the topic
> # STOMP: disconnect from the server (without unsubscribing first)
> # STOMP: connect to the server again
> # STOMP: send a message to the topic
> At this point the server responds with "AMQ339001: Destination does not
> exist: jms.topic.testtopic"
> At this point the topic is still visible in jconsole though so maybe it has
> not disappeared entirely, but anyway, messages cannot be sent to it with
> STOMP any more. Restarting the server makes it possible to send to it again.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
