[
https://issues.apache.org/jira/browse/ARTEMIS-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117497#comment-15117497
]
ASF GitHub Bot commented on ARTEMIS-362:
----------------------------------------
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/348#issuecomment-175096224
I would like to see a description on the commit about what is being
changed...
It's fairly common having to do a git log to figure out when things got
broken... and having to open the JIRA to see what happened is not very
practical.
I can change the commit description before merging though if you don't
mind... but if you can ammend with a description such as
___
ARTEMIS-362 Only sending UDP packets bytes as needed
You can use the next lines to explain things.. etc...
_____
Looking at the website (JIRA on this case) should be an extra step to
eventually look for discussions.
> BroadcastGroupImpl sends datagrams big datagrams full of zero bytes
> -------------------------------------------------------------------
>
> Key: ARTEMIS-362
> URL: https://issues.apache.org/jira/browse/ARTEMIS-362
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 1.0.0, 1.1.0, 1.2.0, 1.3.0
> Environment: OS: Linux
> JVM: Oracle or OpenJDK, 1.7 or 1.8
> Reporter: Lachezar Dobrev
> Labels: newbie, patch, test
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The BroadcastGroupImpl uses improper buffer handling to generate packages for
> broadcasting to a cluster. This results in sending 4096 byte packages (the
> size of the buffer) full of zero bytes with only about 250-300 bytes actual
> payload.
> This incurs needless weight on any underlying network equipment.
> This also may result in loss of service as large packages may be silently
> discarded.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
