[
https://issues.apache.org/jira/browse/AMQ-6169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15150917#comment-15150917
]
ASF subversion and git services commented on AMQ-6169:
------------------------------------------------------
Commit 4e60075a3217bfcaae44fc510e3214aa6c53387d in activemq's branch
refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=4e60075 ]
https://issues.apache.org/jira/browse/AMQ-6169
Add additional null check
> STOMP: Invliad frames are logged in warn messages
> -------------------------------------------------
>
> Key: AMQ-6169
> URL: https://issues.apache.org/jira/browse/AMQ-6169
> Project: ActiveMQ
> Issue Type: Bug
> Components: stomp
> Affects Versions: 5.12.0, 5.12.1, 5.13.0, 5.13.1
> Reporter: Timothy Bish
> Assignee: Timothy Bish
> Fix For: 5.14.0
>
>
> When the STOMP protocol converter encounters a frame that is badly encoded it
> logs out a warning that prints the entire frame contents in the warn message.
> This leads to some confusing results or logs of 'null' as the decoder never
> got to creating a full frame instance before failing.
> If the frame happens to get read but contains corrupted data the log can get
> spammed with garbage characters and becomes somewhat unreadable.
> We should not log the frame if there is one at warn level, perhaps allow for
> trace logging it. We could attempt to log the frame Action if one was read
> and is valid but otherwise should not pollute the logs with entire frames.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
