[
https://issues.apache.org/jira/browse/ARTEMIS-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15151325#comment-15151325
]
ASF GitHub Bot commented on ARTEMIS-391:
----------------------------------------
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/392
ARTEMIS-391 log WARN on cxn limit
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-391
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/392.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #392
----
commit cbcd2b865c54970f05e1ffcc7d2714ae4474cc90
Author: jbertram <jbert...@apache.org>
Date: 2016-02-09T19:42:12Z
ARTEMIS-391 log WARN on cxn limit
----
> Connection Limit doesn't log when over the limit
> ------------------------------------------------
>
> Key: ARTEMIS-391
> URL: https://issues.apache.org/jira/browse/ARTEMIS-391
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 1.2.0
> Reporter: clebert suconic
> Assignee: Justin Bertram
> Fix For: 1.3.0
>
>
> The current security limit doesn't log anything when going beyond the limit:
> there is a Log.DEBUG, and an empty exception that is not shown anywhere.
> else {
> if (ActiveMQServerLogger.LOGGER.isDebugEnabled()) {
> ActiveMQServerLogger.LOGGER.debug(new
> StringBuilder().append("Connection limit of
> ").append(connectionsAllowed).append(" reached. Refusing connection from
> ").append(ctx.channel().remoteAddress()));
> }
> throw new Exception();
> }
> The conneciton should be closed, and proper log should be printed. I think
> this is a situation for log.warn as the admins will need to be aware of it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
