[
https://issues.apache.org/jira/browse/AMQ-5578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15177863#comment-15177863
]
james commented on AMQ-5578:
----------------------------
actually, i don't believe that change invalidates the preallocation fixes. a
(normal) ByteBuffer is just an array under the hood, which will be zeroed
already in java. we are using a variation of this code in production right
now, and i made that improvement as well. the _original_ problem was relying
on sparse writes to the channel itself, not relying on a zeroed out java array.
> preallocate journal files
> -------------------------
>
> Key: AMQ-5578
> URL: https://issues.apache.org/jira/browse/AMQ-5578
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Message Store
> Affects Versions: 5.11.0
> Reporter: Gary Tully
> Assignee: Gary Tully
> Labels: journal, kahaDB, perfomance
> Fix For: 5.14.0
>
>
> Our journals are append only, however we use the size to track journal
> rollover on recovery and replay. We can improve performance if we never
> update the size on disk and preallocate on creation.
> Rework journal logic to ensure size is never updated. This will allow the
> configuration option from https://issues.apache.org/jira/browse/AMQ-4947 to
> be the default.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
