[
https://issues.apache.org/jira/browse/AMQ-5662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15194080#comment-15194080
]
ASF GitHub Bot commented on AMQ-5662:
-------------------------------------
GitHub user northlander opened a pull request:
https://github.com/apache/activemq/pull/176
AMQ-5662 improve Web Console to support retry from all configured DLQs
ActiveMQ Dead letter queues are defined in runtime by individual or shared
DLQ strategy. However, in the web console, the retry command is only active if
a queue starts with "DLQ." or "DLT.". More, it does not really do a retry, only
a move from DLQ.<queuename> to <queuename>. This is not correct, since a DLQ
strategy might use other prefix/suffix to name a DLQ. The correct original
destination is taken from a property of the message, not derived from the DLQ
queue name.
This PR enables the retry command on configured DLQs, regardless of name.
By some reason the default ActiveMQ.DLQ is not detected as a DLQ (looking at
JMX properties of the queue), so this particular queue is also included to show
the retry command. The retry command actually triggers the retry JMX operation.
This PR is actually more or less a duplicate of PR #73, but up to date with
the rest of AMQ, hence pr #73 is closed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/northlander/activemq master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq/pull/176.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #176
----
----
> Improve web console retry to support all DLQ names
> --------------------------------------------------
>
> Key: AMQ-5662
> URL: https://issues.apache.org/jira/browse/AMQ-5662
> Project: ActiveMQ
> Issue Type: Improvement
> Components: webconsole
> Affects Versions: 5.10.2, 5.11.1
> Reporter: Petter Nordlander
> Priority: Minor
> Labels: webconsole
>
> In web console, there is a "retry" link on a message when the name of browsed
> queue starts with DLQ. or DLT. The retry action in the console moves the
> letter to a queue named the same as the dead letter queue but without DLQ. or
> DLT.
> ActiveMQ, however, allows to use any name on a DLQ by using dead letter
> strategies. A shared strategy is the default, and the original destination is
> encoded in each message. The current implementation in web console cannot
> handle the default DLQ strategy in ActiveMQ, which has one single DLQ named
> ActiveMQ.DLQ.
> The suggested fix is to not rely on "move" to do a retry, but to use the
> built in retry mechanism instead. The second part of the fix is to only show
> the retry link when dealing with a real DLQ. A boolean is available through
> JMX.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
