[
https://issues.apache.org/jira/browse/ARTEMIS-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228900#comment-15228900
]
ASF GitHub Bot commented on ARTEMIS-471:
----------------------------------------
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/441#discussion_r58762631
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
---
@@ -464,7 +464,9 @@ private void sendJournalFile(JournalFile[]
journalFiles, JournalContent type) th
for (JournalFile jf : journalFiles) {
if (!started)
return;
--- End diff --
Replicator currentReplicator = replicator;
if (currentReplicator != null) ...
There's no lock in place ... you could have a case where it satisfies the
if and you still get the NPE.. I have seen it happening before in similar cases.
> Potential NPE when sending journal file during replication
> ----------------------------------------------------------
>
> Key: ARTEMIS-471
> URL: https://issues.apache.org/jira/browse/ARTEMIS-471
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 1.2.0
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Fix For: 1.3.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
