[
https://issues.apache.org/jira/browse/ARTEMIS-476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244111#comment-15244111
]
Jiri Danek edited comment on ARTEMIS-476 at 4/16/16 9:14 AM:
-------------------------------------------------------------
I noticed that [~jbertram]'s commit removed information about
-Djava.net.preferIPv4Stack=true from the only place it was mentioned. Do we
really want to keep this around no more? I think so, because it was moved into
the poms themselves, but just to be sure. (reference:
https://github.com/apache/activemq-artemis/search?utf8=%E2%9C%93&q=-Djava.net.preferIPv4Stack%3Dtrue&type=Code)
Examples spring-integration and xa-heuristic are working for me now and they
used to fail, so great success there ;)
was (Author: jdanek):
I noticed that [~jbertram]'s commit removed information about -PnoServer from
the only place it was mentioned. Do we really want to keep this around no more?
(reference:
https://github.com/apache/activemq-artemis/search?l=markdown&q=noServer&type=Code&utf8=%E2%9C%93)
The same goes for -Djava.net.preferIPv4Stack=true, although in this case I am
almost sure the removal was fully intentional.
Examples spring-integration and xa-heuristic are working for me now and they
used to fail, so great success there ;)
> Instructions for running examples are triplicated and confusing in one
> instance
> -------------------------------------------------------------------------------
>
> Key: ARTEMIS-476
> URL: https://issues.apache.org/jira/browse/ARTEMIS-476
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 1.3.0
> Reporter: Jiri Danek
> Assignee: Justin Bertram
> Fix For: 1.3.0
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> Instructions for running examples are given in three different places
> 1) File
> https://github.com/apache/activemq-artemis/blob/master/docs/user-manual/en/examples.md
> says
> 2) README at
> https://github.com/apache/activemq-artemis/blob/master/README.md#examples says
> 3) Another README at
> https://github.com/apache/activemq-artemis/blob/master/examples/README.md
> My qualms:
> Document 2 is the briefest of them all and quite honestly rather confusing.
> (the NB sentence at the end).
> Document 2 states, that `mvn verify` will run all examples, while both other
> documents say that to run all examples, one has to execute `mvn -Pexamples`
> verify. This is an inconsistency.
> Document 3 says that I need to set the -Xmx option only when I want to run
> all examples in a batch, with -Pexamples profile. I think that since each
> example is stopped before another is started, this advice is meaningless.
> What would make sense is to set this option before running any example,
> either single one or in batch. Document 1 does not mention -Xmx at all.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
