[
https://issues.apache.org/jira/browse/ARTEMIS-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255802#comment-15255802
]
ASF GitHub Bot commented on ARTEMIS-501:
----------------------------------------
GitHub user bayern39 opened a pull request:
https://github.com/apache/activemq-artemis/pull/483
ARTEMIS-501 Incorrect log message in class ClientSessionFactoryImpl
https://issues.apache.org/jira/browse/ARTEMIS-501
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bayern39/activemq-artemis fix_log_error
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/483.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #483
----
commit 6fe8ad393aa46e99a88c903a3b774c3aa0eaefe2
Author: bayern39 <[email protected]>
Date: 2016-04-25T02:38:30Z
ARTEMIS-501 Incorrect log message in class ClientSessionFactoryImpl
----
> Incorrect log message in class ClientSessionFactoryImpl
> -------------------------------------------------------
>
> Key: ARTEMIS-501
> URL: https://issues.apache.org/jira/browse/ARTEMIS-501
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
> Affects Versions: 1.2.0
> Reporter: Chen Maoqian
> Fix For: 1.2.0
>
>
> There is incorrect logging message present in method establishNewConnection()
> in class
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl .
> protected RemotingConnection establishNewConnection() {
> ....
> RemotingConnection newConnection = clientProtocolManager.connect(...);
> newConnection.addFailureListener(new
> DelegatingFailureListener(newConnection.getID()));
> schedulePing();
> if (ActiveMQClientLogger.LOGGER.isTraceEnabled()) {
> ActiveMQClientLogger.LOGGER.trace("returning " + connection);
> }
> return newConnection;
> }
> Log message says, that it is returning connection (old one, present as an
> attribute of class), but connection stored in newConnection variable is
> returned (and then it is set as this.connection).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
