[ 
https://issues.apache.org/jira/browse/ARTEMIS-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268676#comment-15268676
 ] 

ASF GitHub Bot commented on ARTEMIS-397:
----------------------------------------

Github user mtaylor commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/497#issuecomment-216523280
  
    Merging thanks!


> MQTT protocol - connection TTL = keepAliveTimeSeconds * 750
> -----------------------------------------------------------
>
>                 Key: ARTEMIS-397
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-397
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 1.0.0, 1.1.0, 1.2.0
>            Reporter: hiawui
>
> For MQTT protocol, the connection TTL is equal to keepAliveTimeSeconds * 750, 
> causes connections always disconnected by timeout. Is it a bug? or why?
> {code:title=MQTTProtocolHandler.java:159|borderStyle=solid}
>    void handleConnect(MqttConnectMessage connect, ChannelHandlerContext ctx) 
> throws Exception {
>       this.ctx = ctx;
>       connectionEntry.ttl = connect.variableHeader().keepAliveTimeSeconds() * 
> 750; // this line!!!, why not multiply by larger than 1000?
>       String clientId = connect.payload().clientIdentifier();
>       session.getConnectionManager().connect(clientId, 
> connect.payload().userName(), connect.payload().password(), 
> connect.variableHeader().isWillFlag(), connect.payload().willMessage(), 
> connect.payload().willTopic(), connect.variableHeader().isWillRetain(), 
> connect.variableHeader().willQos(), 
> connect.variableHeader().isCleanSession());
>    }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to