[
https://issues.apache.org/jira/browse/ARTEMIS-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318861#comment-15318861
]
ASF GitHub Bot commented on ARTEMIS-558:
----------------------------------------
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/569#discussion_r66109312
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
---
@@ -576,23 +576,30 @@ public void lateDeliveryRollback(PagePosition
position) {
@Override
public boolean isComplete(long page) {
- logger.tracef("%s isComplete %d", this, page);
+ if (empty && consumedPages.isEmpty()) {
+ logger.tracef("%s isComplete %d", this, page);
+ }
+
synchronized (consumedPages) {
if (empty && consumedPages.isEmpty()) {
if (logger.isTraceEnabled()) {
- logger.tracef("isComplete(%d)::Subscription %s has
empty=%s, consumedPages.isEmpty=%s", (Object)page, this,
consumedPages.isEmpty());
+ logger.tracef("isComplete(%d)::Subscription %s has
empty=%s, consumedPages.isEmpty=%s", page, this, empty,
consumedPages.isEmpty());
}
return true;
}
PageCursorInfo info = consumedPages.get(page);
if (info == null && empty) {
- logger.tracef("isComplete(%d)::::Couldn't find info and it is
empty", page);
+ if (empty && consumedPages.isEmpty()) {
+ logger.tracef("isComplete(%d)::::Couldn't find info and it
is empty", page);
+ }
return true;
}
else {
- logger.tracef("isComplete(%d)::calling is %s", (Object)page,
this, consumedPages.isEmpty());
+ if (empty && consumedPages.isEmpty()) {
--- End diff --
The intention of this log was to log the else... and look (trace) the
result of isEmpty, etc
I would just remove the if
> java.util.MissingFormatArgumentException: Format specifier '%s' during backup
> activation
> ----------------------------------------------------------------------------------------
>
> Key: ARTEMIS-558
> URL: https://issues.apache.org/jira/browse/ARTEMIS-558
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 1.3.0
> Reporter: Ingo Weiss
> Priority: Minor
>
> If TRACE logs are enabled then sometimes after failover there is warning in
> log of backup server:
> {code}
> 11:17:05,642 WARN [org.apache.activemq.artemis.core.server] (AMQ119000:
> Activation for server
> ActiveMQServerImpl::serverUUID=a8a10b35-2742-11e6-9dee-5b1da6be834d)
> AMQ222038: Starting paging on address 'jms.queue.OutQueue'; size is
> currently: 1,053,248 bytes; max-size-bytes: 1,048,576
> LogManager error of type FORMAT_FAILURE: Formatting error
> java.util.MissingFormatArgumentException: Format specifier '%s'
> at java.util.Formatter.format(Formatter.java:2519)
> at java.util.Formatter.format(Formatter.java:2455)
> at java.lang.String.format(String.java:2940)
> at org.jboss.logmanager.ExtLogRecord.formatRecord(ExtLogRecord.java:444)
> at
> org.jboss.logmanager.ExtLogRecord.getFormattedMessage(ExtLogRecord.java:407)
> at
> org.jboss.logmanager.formatters.Formatters$13.renderRaw(Formatters.java:606)
> at
> org.jboss.logmanager.formatters.Formatters$JustifyingFormatStep.render(Formatters.java:225)
> at
> org.jboss.logmanager.formatters.MultistepFormatter.format(MultistepFormatter.java:83)
> at org.jboss.logmanager.ExtFormatter.format(ExtFormatter.java:32)
> at
> org.jboss.logmanager.handlers.WriterHandler.doPublish(WriterHandler.java:46)
> at org.jboss.logmanager.ExtHandler.publish(ExtHandler.java:76)
> at org.jboss.logmanager.LoggerNode.publish(LoggerNode.java:314)
> at org.jboss.logmanager.LoggerNode.publish(LoggerNode.java:322)
> at org.jboss.logmanager.LoggerNode.publish(LoggerNode.java:322)
> at org.jboss.logmanager.LoggerNode.publish(LoggerNode.java:322)
> at org.jboss.logmanager.LoggerNode.publish(LoggerNode.java:322)
> at org.jboss.logmanager.LoggerNode.publish(LoggerNode.java:322)
> at org.jboss.logmanager.LoggerNode.publish(LoggerNode.java:322)
> at org.jboss.logmanager.LoggerNode.publish(LoggerNode.java:322)
> at org.jboss.logmanager.LoggerNode.publish(LoggerNode.java:322)
> at org.jboss.logmanager.LoggerNode.publish(LoggerNode.java:322)
> at org.jboss.logmanager.Logger.logRaw(Logger.java:850)
> at org.jboss.logmanager.Logger.log(Logger.java:802)
> at
> org.jboss.logging.JBossLogManagerLogger.doLogf(JBossLogManagerLogger.java:53)
> at org.jboss.logging.Logger.tracef(Logger.java:315)
> at
> org.apache.activemq.artemis.core.paging.cursor.impl.PageSubscriptionImpl.isComplete(PageSubscriptionImpl.java:561)
> at
> org.apache.activemq.artemis.core.paging.cursor.impl.PageCursorProviderImpl.checkPageCompletion(PageCursorProviderImpl.java:492)
> at
> org.apache.activemq.artemis.core.paging.cursor.impl.PageCursorProviderImpl.cleanup(PageCursorProviderImpl.java:376)
> at
> org.apache.activemq.artemis.core.paging.cursor.impl.PageCursorProviderImpl.processReload(PageCursorProviderImpl.java:227)
> at
> org.apache.activemq.artemis.core.paging.impl.PagingStoreImpl.processReload(PagingStoreImpl.java:311)
> at
> org.apache.activemq.artemis.core.paging.impl.PagingManagerImpl.processReload(PagingManagerImpl.java:243)
> at
> org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager.loadMessageJournal(JournalStorageManager.java:1588)
> at
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.loadJournals(ActiveMQServerImpl.java:1708)
> at
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.initialisePart2(ActiveMQServerImpl.java:1602)
> at
> org.apache.activemq.artemis.core.server.impl.SharedStoreBackupActivation.run(SharedStoreBackupActivation.java:89)
> at java.lang.Thread.run(Thread.java:745)
> {code}
> It has no functional impact. It's unwanted stack trace in server.log.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
