[
https://issues.apache.org/jira/browse/ARTEMIS-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15345014#comment-15345014
]
Justin Bertram commented on ARTEMIS-590:
----------------------------------------
I think this idea has merit. However, I'd like to keep the system properties
to a minimum as they shouldn't be the normal way a connector is configured.
The SSL related system properties only exist because that's the way Java has
historically configured keystore-related details. The ideal way to configure
this is with a transport constant so you could use something like
{{tcp://127.0.0.1:61616?sslEnabled=true;useDefaultSSLContext=true}}. If this
approach is taken then the question arises as to which settings take precedence
since this new constant and the existing keystore-related constants as well as
the system properties are mutually exclusive. Can you clarify how you envision
this working?
> Allow NettyConnector to use the default SSL Context
> ---------------------------------------------------
>
> Key: ARTEMIS-590
> URL: https://issues.apache.org/jira/browse/ARTEMIS-590
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Dominique Toupin
> Assignee: Justin Bertram
> Priority: Minor
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> It would be nice if NettyConnector was able to use the "default" SSL Context
> (SSLContext.getDefault()) as the client might already have defined it...
> I believe all it takes is a new system property (e.g.
> org.apache.activemq.ssl.useDefaultSSLContext) and the addition of an if in
> NettyConnector.java where the SSL Context would otherwise be created using
> the other org.apache.activemq.ssl.* properties
> e.g.
> {code:java}
> @@ -396,11 +395,7 @@ public class NettyConnector extends AbstractConnector {
> final SSLContext context;
> if (sslEnabled) {
> try {
> + if
> (System.getProperty(ACTIVEMQ_USE_DEFAULT_SSL_CONTEXT_PROP_NAME) != null)
> + context = SSLContext.getDefault();
> + else {
> // HORNETQ-680 - override the server-side config if
> client-side system properties are set
> String realKeyStorePath = keyStorePath;
> String realKeyStoreProvider = keyStoreProvider;
> String realKeyStorePassword = keyStorePassword;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
