[ 
https://issues.apache.org/jira/browse/ARTEMIS-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363315#comment-15363315
 ] 

ASF GitHub Bot commented on ARTEMIS-584:
----------------------------------------

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/621#discussion_r69644037
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/security/ActiveMQJAASSecurityManager.java
 ---
    @@ -80,31 +81,41 @@ public ActiveMQJAASSecurityManager(String 
configurationName, String certificateC
        }
     
        @Override
    -   public boolean validateUser(String user, String password) {
    --- End diff --
    
    I just checked and Wildfly won't build after this change.
    
    I know at least one user who was writing his own SecurityManager, so this 
would break not just wildfly.
    
    it's part of the SPI, so we can't change it without breaking API. 
    
    as we talked, make a SecurityManager3 and add what you need there, check of 
instanceof of the new corrent interface.


> Add an option to populate JMSXUserID
> ------------------------------------
>
>                 Key: ARTEMIS-584
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-584
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Lionel Cons
>            Assignee: Justin Bertram
>
> ActiveMQ 5.x can be configured to set JMSXUserID to the authenticated user, 
> see http://activemq.apache.org/jmsxuserid.html.
> This feature is very important for auditing purposes, to find out who sent a 
> given message.
> Please add a similar functionality to Artemis, including with STOMP mapping.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to