[ 
https://issues.apache.org/jira/browse/ARTEMIS-611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385591#comment-15385591
 ] 

Lionel Cons commented on ARTEMIS-611:
-------------------------------------

Thanks for having improved (and documented) Artemis' support for STOMP 
heart-beats.

It seems that some debug messages have been left in the code, see ARTEMIS-644.

Personally, for simplicity sake, I would have preferred {{connectionTtlMin}} 
and {{connectionTtlMax}} to be the min and max heart-beat values that can be 
negotiated, independently from {{heartBeatConnectionTtlModifer}}.

My heart-beat tests went fine. However, in case of lack of heart-beat, Artemis 
simply closes the connection. I would prefer Artemis sending an {{ERROR}} frame 
before closing the connection. This way, if the client is not dead (but simply 
silent), it will know why its connection has been closed.

> STOMP 1.0 consumers are killed after some time
> ----------------------------------------------
>
>                 Key: ARTEMIS-611
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-611
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 1.3.0
>            Reporter: Lionel Cons
>            Assignee: Justin Bertram
>             Fix For: 1.4.0
>
>
> With the default configuration, a STOMP 1.0 consumer that subscribes to a 
> destination and waits for messages to come gets killed after some time (in 
> case there are no messages coming).
> The broker logs:
> {code}
> 2016-07-04 09:34:31,260 [org.apache.activemq.artemis.core.server] WARN 
> AMQ222067: Connection failure has been detected: AMQ119014: Did not receive 
> data from /192.168.47.193:54716. It is likely the client has exited or 
> crashed without closing its connection, or the network between the server and 
> client has failed. You also might have configured connection-ttl and 
> client-failure-check-period incorrectly. Please check user manual for more 
> information. The connection will now be closed. [code=CONNECTION_TIMEDOUT]
> 2016-07-04 09:34:31,261 [org.apache.activemq.artemis.core.server] WARN 
> AMQ222061: Client connection failed, clearing up resources for session 
> 9ae78c80-41b9-11e6-8647-02163e018512
> 2016-07-04 09:34:31,263 [org.apache.activemq.artemis.core.server] WARN 
> AMQ222107: Cleared up resources for session 
> 9ae78c80-41b9-11e6-8647-02163e018512
> {code}
> STOMP 1.0 clients do not support heart-beats and the broker should not kill 
> connections after some period of inactivity.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to