[
https://issues.apache.org/jira/browse/ARTEMIS-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15388362#comment-15388362
]
ASF GitHub Bot commented on ARTEMIS-548:
----------------------------------------
Github user johnament commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/653#discussion_r71780013
--- Diff:
artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompProtocolManager.java
---
@@ -393,7 +393,8 @@ public void unsubscribe(StompConnection connection,
String subscriptionID,
String durableSubscriberName) throws Exception {
StompSession stompSession = getSession(connection);
- boolean unsubscribed = stompSession.unsubscribe(subscriptionID,
durableSubscriberName);
+ String clientID = (connection.getClientID() != null) ?
connection.getClientID() : null;
--- End diff --
null check looks redundant, its always the value of
`connection.getClientID()`
> Add STOMP-based ability to delete durable subscriber
> ----------------------------------------------------
>
> Key: ARTEMIS-548
> URL: https://issues.apache.org/jira/browse/ARTEMIS-548
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 1.2.0
> Reporter: Justin Bertram
> Assignee: Justin Bertram
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
