[
https://issues.apache.org/jira/browse/ARTEMIS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15450213#comment-15450213
]
clebert suconic edited comment on ARTEMIS-699 at 8/30/16 9:30 PM:
------------------------------------------------------------------
I have merged the fix written by [~jbertram]. There still a wish list for a
test.
[~leto] do you know how to make a failing test? we tried.. we got logs but it
never failed to deliver a message.
was (Author: clebertsuconic):
I have merged the fix. There still a wish list for a test.
[~leto] do you know how to make a failing test? we tried.. we got logs but it
never failed to deliver a message.
> Reaper seems to clog up the journal, and messages fail to deliver
> -----------------------------------------------------------------
>
> Key: ARTEMIS-699
> URL: https://issues.apache.org/jira/browse/ARTEMIS-699
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 1.3.0
> Reporter: Michael Brown
> Assignee: Justin Bertram
> Priority: Critical
>
> We are seeing the exception (below) regularly, and a loss of message
> delivery, which only goes away if we delete the journal and restart. This is
> with the following grouping options in broker.xml:
> {code:xml}
> <grouping-handler name="jms-recordsure-grouping-handler">
> <type>LOCAL</type>
> <address>jms</address>
> <timeout>5000</timeout>
> <group-timeout>300000</group-timeout>
> <reaper-period>30000</reaper-period>
> </grouping-handler>
> {code}
> If we remove timeout/group-timeout/reaper-period the issues go away.
> Having traced through the code I see this issue in LocalGroupHandling.java:
> {code:java}
> if (expiredGroups >= 1000 && txID >= 0) {
> expiredGroups = 0;
> txID = -1;
> storageManager.commitBindings(txID);
> }
> {code}
> The method 'commitBindings' has (via dependencies) an explicit check that
> will throw an exception if txID is -1. This code must fail.
> I suggest a fix that moves the reset of txID to be after the commitBindings
> call, as follows:
> {code:java}
> if (expiredGroups >= 1000 && txID >= 0) {
> storageManager.commitBindings(txID);
> expiredGroups = 0;
> txID = -1;
> }
> {code}
> {noformat}
> 2016-08-24 13:09:01,660 WARN [org.apache.activemq.artemis.core.server]
> AMQ222114: Unable to delete group binding info
> c2e95857-87ad-455a-ba67-1c63ac351cc8.ad900ba9-69e3-11e6-86b2-0242ac110003:
> java.lang.IllegalStateException: Cannot find tx with id -1
> at
> org.apache.activemq.artemis.core.journal.impl.JournalImpl.appendCommitRecord(JournalImpl.java:1013)
> [artemis-journal-1.3.0.jar:1.3.0]
> at
> org.apache.activemq.artemis.core.journal.impl.JournalBase.appendCommitRecord(JournalBase.java:112)
> [artemis-journal-1.3.0.jar:1.3.0]
> at
> org.apache.activemq.artemis.core.journal.impl.JournalImpl.appendCommitRecord(JournalImpl.java:79)
> [artemis-journal-1.3.0.jar:1.3.0]
> at
> org.apache.activemq.artemis.core.replication.ReplicatedJournal.appendCommitRecord(ReplicatedJournal.java:164)
> [artemis-server-1.3.0.jar:1.3.0]
> at
> org.apache.activemq.artemis.core.persistence.impl.journal.AbstractJournalStorageManager.commitBindings(AbstractJournalStorageManager.java:650)
> [artemis-server-1.3.0.jar:1.3.0]
> at
> org.apache.activemq.artemis.core.server.group.impl.LocalGroupingHandler$GroupIdReaper.run(LocalGroupingHandler.java:449)
> [artemis-server-1.3.0.jar:1.3.0]
> at
> org.apache.activemq.artemis.utils.OrderedExecutorFactory$OrderedExecutor$ExecutorTask.run(OrderedExecutorFactory.java:103)
> [artemis-core-client-1.3.0.jar:1.3.0]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> [rt.jar:1.8.0_102]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> [rt.jar:1.8.0_102]
> at java.lang.Thread.run(Thread.java:745) [rt.jar:1.8.0_102]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
