[
https://issues.apache.org/jira/browse/ARTEMIS-706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452247#comment-15452247
]
ASF GitHub Bot commented on ARTEMIS-706:
----------------------------------------
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/740#discussion_r76986566
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
---
@@ -345,16 +357,19 @@ public void disconnect(boolean criticalError) {
}
@Override
- public boolean checkDataReceived() {
- boolean res = dataReceived;
-
- dataReceived = false;
-
- return res;
+ public void flush() {
+ checkInactivity();
}
- @Override
- public void flush() {
+ private void checkInactivity() {
+ if (!this.useKeepAlive) {
--- End diff --
Call the super method then?
> InactivityIOException - Perhaps No Keep Alives From Broker?
> -----------------------------------------------------------
>
> Key: ARTEMIS-706
> URL: https://issues.apache.org/jira/browse/ARTEMIS-706
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: OpenWire
> Affects Versions: 1.4.0
> Reporter: Howard Gao
> Assignee: Howard Gao
> Fix For: 1.5.0
>
>
> Broker doesn't handle the openwire Inactivity timeouts properly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
