Martin Styk created ARTEMIS-710:
-----------------------------------
Summary: Avoid inefficient iteration over Map
Key: ARTEMIS-710
URL: https://issues.apache.org/jira/browse/ARTEMIS-710
Project: ActiveMQ Artemis
Issue Type: Improvement
Components: Broker
Affects Versions: 1.4.0
Reporter: Martin Styk
Priority: Minor
On few places in Artemis code, inefficient iteration over Map object is
present.
Example
{code:java}
Map<Thread, StackTraceElement[]> threadMap = Thread.getAllStackTraces();
for (Thread thread : threadMap.keySet()) {
StackTraceElement[] stack = threadMap.get(thread);
....
{code}
To make it more efficient, we should use Map.Entry instead of getting keySet
and than finding corresponding value.
Places where this could be changed
* ScaleDownHandler#scaleDownDuplicateIDs
* PostOfficeJournalLoader#recoverPendingPageCounters
* ActiveMQTestBase#tearDown
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
