[ 
https://issues.apache.org/jira/browse/ARTEMIS-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530364#comment-15530364
 ] 

ASF GitHub Bot commented on ARTEMIS-739:
----------------------------------------

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/806#discussion_r80976998
  
    --- Diff: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/DeadLetterAddressTest.java
 ---
    @@ -82,6 +87,43 @@ public void testBasicSend() throws Exception {
           Assert.assertEquals(m.getBodyBuffer().readString(), "heyho!");
        }
     
    +   @Test
    +   public void testLargeMessageFileLeak() throws Exception {
    +      // only run this on *nix systems which will have the 
com.sun.management.UnixOperatingSystemMXBean (needed to check open file count)
    +      Assume.assumeTrue(File.separatorChar == '/');
    --- End diff --
    
    I tested it on windows and it does compile file...
    
    
    Can you change this to some sort of instanceof?


> Large messages failing with "(Too many open files)"
> ---------------------------------------------------
>
>                 Key: ARTEMIS-739
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-739
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 1.3.0, 1.4.0
>            Reporter: Damien Hollis
>            Assignee: Justin Bertram
>            Priority: Critical
>
> We are processing a large number of large messages and many of them are being 
> put into the dead-letter queue as part of a transaction rollback.  I suspect 
> that during the rollback the large message is not being released properly and 
> as a result the error below eventually occurs.  This may be a more general 
> issue but so far we have only seen this issue when processing messages 
> successfully (although another person in the team mentioned that there seem 
> to be a lot of large messages hanging around).
> I noted we are not using the latest version, so I'm in the process of 
> creating a new build and I will test with version 1.4 later today or tomorrow.
> {noformat}
> org.apache.activemq.artemis.core.server | AMQ222010: Critical IO Error, 
> shutting
> down the server. file=NIOSequentialFile 
> /var/data/artemis/large-messages/2147660860.msg, 
> message=/var/data/artemis/large-messages/2147660860.msg (Too many open files)
> org.apache.activemq.artemis.api.core.ActiveMQIOErrorException: 
> /var/data/artemis/large-messages/2147660860.msg (Too many open files)
>         at 
> org.apache.activemq.artemis.core.io.nio.NIOSequentialFile.open(NIOSequentialFile.java:101)
>         at 
> org.apache.activemq.artemis.core.io.nio.NIOSequentialFile.open(NIOSequentialFile.java:85)
>         at 
> org.apache.activemq.artemis.core.persistence.impl.journal.LargeServerMessageImpl$DecodingContext.open(LargeServerMessageImpl.java:426)
>         at 
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl$LargeMessageDeliverer.deliver(ServerConsumerImpl.java:1131)
>         at 
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:414)
>         at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.proceedDeliver(QueueImpl.java:2464)
>         at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.deliver(QueueImpl.java:1956)
>         at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.access$1500(QueueImpl.java:99)
>         at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl$DeliverRunner.run(QueueImpl.java:2695)
>         at 
> org.apache.activemq.artemis.utils.OrderedExecutorFactory$OrderedExecutor$ExecutorTask.run(OrderedExecutorFactory.java:103)
>         at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>         at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>         at java.lang.Thread.run(Thread.java:745)
> Caused by: java.io.FileNotFoundException: 
> /var/data/artemis/large-messages/2147660860.msg (Too many open files)
>         at java.io.RandomAccessFile.open0(Native Method)
>         at java.io.RandomAccessFile.open(RandomAccessFile.java:316)
>         at java.io.RandomAccessFile.<init>(RandomAccessFile.java:243)
>         at 
> org.apache.activemq.artemis.core.io.nio.NIOSequentialFile.open(NIOSequentialFile.java:91)
>         ... 12 common frames omitted
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to