[ 
https://issues.apache.org/jira/browse/ARTEMIS-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15548223#comment-15548223
 ] 

Benjamin Graf commented on ARTEMIS-752:
---------------------------------------

The patch of this issue is buggy:

1. Missing 's' in the name of the first if statement parameter
{code:java}
if (!protocol.contains(protocol)) {
    protocols.add(protocol);
}
{code}

2. Throwing NPE for protocol artemis because if missing protocol parameter
{code}
2016-10-05 11:31:44,536 | ERROR | ctivemq.artemis) | artemis-server-osgi        
      | 69 - org.apache.activemq.artemis-server-osgi - 1.5.0.SNAPSHOT | 
[org.apache.activemq.artemis.osgi.OsgiBroker(6)] The activate method has thrown 
an exception
java.lang.NullPointerException
        at 
org.apache.activemq.artemis.osgi.OsgiBroker.getRequiredProtocols(OsgiBroker.java:147)
        at 
org.apache.activemq.artemis.osgi.OsgiBroker.activate(OsgiBroker.java:94)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native 
Method)[:1.8.0_102]
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)[:1.8.0_102]
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)[:1.8.0_102]
        at java.lang.reflect.Method.invoke(Method.java:498)[:1.8.0_102]
        at 
org.apache.felix.scr.impl.inject.BaseMethod.invokeMethod(BaseMethod.java:224)[77:org.apache.felix.scr:2.0.6]
        at 
org.apache.felix.scr.impl.inject.BaseMethod.access$500(BaseMethod.java:39)[77:org.apache.felix.scr:2.0.6]
        at 
org.apache.felix.scr.impl.inject.BaseMethod$Resolved.invoke(BaseMethod.java:617)[77:org.apache.felix.scr:2.0.6]
        at 
org.apache.felix.scr.impl.inject.BaseMethod.invoke(BaseMethod.java:501)[77:org.apache.felix.scr:2.0.6]
        at 
org.apache.felix.scr.impl.inject.ActivateMethod.invoke(ActivateMethod.java:302)[77:org.apache.felix.scr:2.0.6]
        at 
org.apache.felix.scr.impl.inject.ActivateMethod.invoke(ActivateMethod.java:294)[77:org.apache.felix.scr:2.0.6]
        at 
org.apache.felix.scr.impl.manager.SingleComponentManager.createImplementationObject(SingleComponentManager.java:297)[77:org.apache.felix.scr:2.0.6]
        at 
org.apache.felix.scr.impl.manager.SingleComponentManager.createComponent(SingleComponentManager.java:108)[77:org.apache.felix.scr:2.0.6]
        at 
org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:906)[77:org.apache.felix.scr:2.0.6]
        at 
org.apache.felix.scr.impl.manager.SingleComponentManager.getServiceInternal(SingleComponentManager.java:879)[77:org.apache.felix.scr:2.0.6]
        at 
org.apache.felix.scr.impl.manager.AbstractComponentManager.activateInternal(AbstractComponentManager.java:748)[77:org.apache.felix.scr:2.0.6]
        at 
org.apache.felix.scr.impl.manager.AbstractComponentManager.enableInternal(AbstractComponentManager.java:674)[77:org.apache.felix.scr:2.0.6]
        at 
org.apache.felix.scr.impl.manager.AbstractComponentManager.enable(AbstractComponentManager.java:429)[77:org.apache.felix.scr:2.0.6]
        at 
org.apache.felix.scr.impl.manager.ConfigurableComponentHolder.configurationUpdated(ConfigurableComponentHolder.java:431)[77:org.apache.felix.scr:2.0.6]
        at 
org.apache.felix.scr.impl.manager.RegionConfigurationSupport.configurationEvent(RegionConfigurationSupport.java:273)[77:org.apache.felix.scr:2.0.6]
        at 
org.apache.felix.cm.impl.ConfigurationManager$FireConfigurationEvent.sendEvent(ConfigurationManager.java:2046)[3:org.apache.felix.configadmin:1.8.8]
        at 
org.apache.felix.cm.impl.ConfigurationManager$FireConfigurationEvent.run(ConfigurationManager.java:2014)[3:org.apache.felix.configadmin:1.8.8]
        at 
org.apache.felix.cm.impl.UpdateThread.run0(UpdateThread.java:143)[3:org.apache.felix.configadmin:1.8.8]
        at 
org.apache.felix.cm.impl.UpdateThread.run(UpdateThread.java:110)[3:org.apache.felix.configadmin:1.8.8]
        at java.lang.Thread.run(Thread.java:745)[:1.8.0_102]
{code}


> In VM Acceptor does not start when running artemis inside of karaf
> ------------------------------------------------------------------
>
>                 Key: ARTEMIS-752
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-752
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 1.3.0, 1.4.0
>            Reporter: Ryan Yeats
>            Assignee: Justin Bertram
>             Fix For: 1.5.0
>
>         Attachments: artemis.xml, threaddump-1474917859904.tdump
>
>
> simply adding <acceptor name="invm-acceptor">vm://0</acceptor> to the list of 
> acceptors to the default artemis.xml installed into karaf by the artemis 
> feature will cause it to hang on startup waiting for the invm acceptor to 
> start up.
> Still waiting for [INVM-ACCEPTOR]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to