[
https://issues.apache.org/jira/browse/ARTEMIS-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15550784#comment-15550784
]
ASF GitHub Bot commented on ARTEMIS-770:
----------------------------------------
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/820
There are a few regressions under
org.apache.activemq.artemis.tests.integration.amqp.*
AmqpTransactionTest::testReceiversCommitAndRollbackWithMultipleSessionsInSingleTX
and
ProtonPubTest has a few failing.
You think you could look into those and amend the commit?
But overall it looks great!
> AMQP: Incorrect or inefficient transformation of AMQP Messages
> ---------------------------------------------------------------
>
> Key: ARTEMIS-770
> URL: https://issues.apache.org/jira/browse/ARTEMIS-770
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
> Affects Versions: 1.4.0
> Reporter: Timothy Bish
>
> The AMQP Message Transformations done in the protocol module can at times
> produces incorrect conversion are append additional data not present in the
> original AMQP message.
> Some noted issues
> * The Message Format value is not preserved from the original delivery.
> * Message Headers are added to outbound messages where the original message
> did not have any which adds unnecessary overhead.
> * Message Properties can be added to outbound messages where the original did
> not have any which adds unnecessary overhead and is illegal as the properties
> section is immutable in AMQP.
> * Additional Application Properties are applied to outbound messages which
> are meant to be immutable.
> * Some internal properties from the core message are applied to the Message
> Annotations unnecessarily adding overhead to the outbound message.
> * The outbound message can contain a body that differs from the inbound
> version in some cases
> * Object serialization / deserialization is done on types from the incoming
> message that are wrapped in an AmqpValue instead of falling back to native
> encoding to preserve the original Message body value.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
