[ 
https://issues.apache.org/jira/browse/ARTEMIS-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582692#comment-15582692
 ] 

ASF GitHub Bot commented on ARTEMIS-801:
----------------------------------------

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/845#discussion_r83682900
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/reload/ReloadManagerImpl.java
 ---
    @@ -92,7 +95,17 @@ private ReloadRegistry getRegistry(URL uri) {
           private final List<ReloadCallback> callbacks = new LinkedList<>();
     
           ReloadRegistry(URL uri) {
    -         this.file = new File(uri.getPath());
    +         String filePath = null;
    +         try {
    +            filePath = URLDecoder.decode(uri.getPath(), 
StandardCharsets.UTF_8.name());
    --- End diff --
    
    hmmm.. the issue is on the reload manager only?


> Several tests fail if the project is located on path with special characters
> ----------------------------------------------------------------------------
>
>                 Key: ARTEMIS-801
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-801
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>            Reporter: Erich Duda
>
> If the path to file contains special characters such as '&', the file is not 
> found.
> {code}
> java.nio.file.NoSuchFileException: 
> /mnt/hudson_workspace/workspace/artemis-project-testsuite-matrix-upstream/NATIVES/false/jdk/openjdk1.8_local/label/RHEL6%26%26x86_64/artemis-cli/target/test-classes/broker-reload.xml
>       at 
> sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)
>       at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
>       at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
>       at 
> sun.nio.fs.UnixFileSystemProvider.newByteChannel(UnixFileSystemProvider.java:214)
>       at java.nio.file.Files.newByteChannel(Files.java:361)
>       at java.nio.file.Files.newByteChannel(Files.java:407)
>       at java.nio.file.Files.readAllBytes(Files.java:3152)
>       at 
> org.apache.activemq.cli.test.FileBrokerTest.replacePatternInFile(FileBrokerTest.java:145)
>       at 
> org.apache.activemq.cli.test.FileBrokerTest.testConfigFileReload(FileBrokerTest.java:137)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to