ASF GitHub Bot commented on ARTEMIS-793:

Github user clebertsuconic commented on the issue:

    There is one change that is wrong here. You are using the 
ProtocolTrackerCallback to admin DataSources. Can you separate this into a 
separate class? DataSourceTrackerCallback?
    And instead of returning a true or false, can you return the name of the 
    Also: I coudln't comment on the change here given the merge mess you have 
on this branch now. Can  you execute these commands please?
    git pull --rebase upstream master
    git push origin -f your-branch-name

> Improvement to OSGi integration 
> --------------------------------
>                 Key: ARTEMIS-793
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-793
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker, osgi
>            Reporter: Benjamin Graf
>             Fix For: 1.5.0
> ARTEMIS-714 adds ability to configure external DataSource for usage instead 
> of hardcoded driver. This feature should also  be usable in OSGi environments 
> like Karaf.

This message was sent by Atlassian JIRA

Reply via email to