[ 
https://issues.apache.org/jira/browse/ARTEMIS-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15584578#comment-15584578
 ] 

ASF GitHub Bot commented on ARTEMIS-801:
----------------------------------------

Github user dudaerich commented on the issue:

    https://github.com/apache/activemq-artemis/pull/845
  
    Hi @clebertsuconic
    my intention here was to fix tests which fail in our CI. The path to 
project directory contains '&' characters. Example of path:
    ```
    .../jdk/java18_default/label/RHEL6&&x86_64/...
    ```
    I didn't realize that this could cause problems at more places in the code. 
Using URI to open a file is much better solution than decoding the URL :). 
Thanks for the proper fix, it looks good. I executed the tests with your fix 
and they passed.


> Server doesn't support special characters on the path
> -----------------------------------------------------
>
>                 Key: ARTEMIS-801
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-801
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>            Reporter: Erich Duda
>            Assignee: clebert suconic
>             Fix For: 1.5.0
>
>
> If the path to file contains special characters such as '&', the file is not 
> found.
> {code}
> java.nio.file.NoSuchFileException: 
> /mnt/hudson_workspace/workspace/artemis-project-testsuite-matrix-upstream/NATIVES/false/jdk/openjdk1.8_local/label/RHEL6%26%26x86_64/artemis-cli/target/test-classes/broker-reload.xml
>       at 
> sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)
>       at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
>       at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
>       at 
> sun.nio.fs.UnixFileSystemProvider.newByteChannel(UnixFileSystemProvider.java:214)
>       at java.nio.file.Files.newByteChannel(Files.java:361)
>       at java.nio.file.Files.newByteChannel(Files.java:407)
>       at java.nio.file.Files.readAllBytes(Files.java:3152)
>       at 
> org.apache.activemq.cli.test.FileBrokerTest.replacePatternInFile(FileBrokerTest.java:145)
>       at 
> org.apache.activemq.cli.test.FileBrokerTest.testConfigFileReload(FileBrokerTest.java:137)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to