[
https://issues.apache.org/jira/browse/ARTEMIS-830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615169#comment-15615169
]
ASF GitHub Bot commented on ARTEMIS-830:
----------------------------------------
GitHub user bennetelli opened a pull request:
https://github.com/apache/activemq-artemis/pull/873
ARTEMIS-830 Remove cyclic dependencies
Removes cyclic dependencies between classes and packages in the
artemis-jdbc-store projetct by moving classes and methods to other locations
and reducing the visibility of classes, fields and methods. Solving cyclic
dependencies is important to keep the codebase maintainable. Scenarios where
"everything uses everything" should be avoided.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bennetelli/activemq-artemis master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/873.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #873
----
commit 1d22953bc17815df1716fe79d48497cb180afaf8
Author: Bennet Schulz <[email protected]>
Date: 2016-10-28T11:46:00Z
ARTEMIS-830 Remove cyclic dependencies
Removes cyclic dependencies between classes and packages in the
artemis-jdbc-store projetct by moving classes and methods to other locations
and reducing the visibility of classes, fields and methods. Solving cyclic
dependencies is important to keep the codebase maintainable. Scenarios where
"everything uses everything" should be avoided.
----
> Remove cyclic dependencies between packages/classes in artemis-jdbc-store
> -------------------------------------------------------------------------
>
> Key: ARTEMIS-830
> URL: https://issues.apache.org/jira/browse/ARTEMIS-830
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Bennet Schulz
>
> Currently there are lots of dependencies between classes and packages in
> artemis-jdbc-store. These cyclic dependencies should be solved and the
> codebase should be free from tangles to keep it maintainable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
