[
https://issues.apache.org/jira/browse/ARTEMIS-865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitrii Tikhomirov updated ARTEMIS-865:
---------------------------------------
Description:
ARTEMIS-603 fixed, unfortunately in Artemis 1.5 some more were introduced. When
I grep the code I see following classes which are of interest of EAP 7.1 and
contains printStackTrace():
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java:
e.printStackTrace();
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java:
e.printStackTrace();
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java:
e.printStackTrace();
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java:
e.printStackTrace();
artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/file/JDBCSequentialFile.java:
e.printStackTrace();
artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/file/JDBCSequentialFile.java:
e.printStackTrace();
artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/journal/JDBCJournalImpl.java:
e.printStackTrace();
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnectionFactory.java:
e.printStackTrace();
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jndi/ActiveMQInitialContextFactory.java:
e.printStackTrace();
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/management/impl/JMSTopicControlImpl.java:
e.printStackTrace();
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/impl/JMSServerManagerImpl.java:
e.printStackTrace();
artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalFileImpl.java:
e.printStackTrace();
artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java:
e.printStackTrace();
artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java:
e.printStackTrace();
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/nullpm/NullStorageManager.java:
code.printStackT
was:
ActiveMQActivationSpec.validate() method should not call e.printStackTrace();
in catch block. It should be properly logged:
try {
...
catch (IntrospectionException e) {
e.printStackTrace();
}
The same issue is in:
InVMAcceptor.stop()
NettyAcceptor.stop()
ClusterManager.clear()
ClusterManager.intercept()
ColocatedHAManager.stop()
ClusterConnectionImpl.disconnectRecord()
ClusterConnectionImpl.removeRecord()
ActiveMQServerImpl.freezeConnections()
ColocatedActivation.allVotesCast()
ColocatedActivation.getActivationChannelHandler()
FileLockNodeManager.startLiveNode()
InVMNodeManager.startLiveNode()
RefsOperation.afterRollback()
ServerSessionImpl.xaForget()
SharedNothingBackupActivation.run()
SharedStoreBackupActivation.run()
ManagementServiceImpl.unregisterAcceptors()
> CLONE - Remove e.printStackTrace() from code
> --------------------------------------------
>
> Key: ARTEMIS-865
> URL: https://issues.apache.org/jira/browse/ARTEMIS-865
> Project: ActiveMQ Artemis
> Issue Type: Task
> Affects Versions: 1.5.0
> Reporter: Dmitrii Tikhomirov
> Priority: Minor
> Fix For: 1.6.0
>
>
> ARTEMIS-603 fixed, unfortunately in Artemis 1.5 some more were introduced.
> When I grep the code I see following classes which are of interest of EAP 7.1
> and contains printStackTrace():
> artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java:
> e.printStackTrace();
> artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java:
> e.printStackTrace();
> artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java:
> e.printStackTrace();
> artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java:
> e.printStackTrace();
> artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/file/JDBCSequentialFile.java:
> e.printStackTrace();
> artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/file/JDBCSequentialFile.java:
> e.printStackTrace();
> artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/journal/JDBCJournalImpl.java:
> e.printStackTrace();
> artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnectionFactory.java:
> e.printStackTrace();
> artemis-jms-client/src/main/java/org/apache/activemq/artemis/jndi/ActiveMQInitialContextFactory.java:
> e.printStackTrace();
> artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/management/impl/JMSTopicControlImpl.java:
> e.printStackTrace();
> artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/impl/JMSServerManagerImpl.java:
> e.printStackTrace();
> artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalFileImpl.java:
> e.printStackTrace();
> artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java:
> e.printStackTrace();
> artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java:
> e.printStackTrace();
> artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/nullpm/NullStorageManager.java:
> code.printStackT
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)