[
https://issues.apache.org/jira/browse/ARTEMIS-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748775#comment-15748775
]
ASF GitHub Bot commented on ARTEMIS-883:
----------------------------------------
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/907
Summary for the situation of this PR:
This PR is about fixing blocking client producers in OpenWire...
The implementation is currently using setAutoRead, and there is a test
failing Howard was trying to fix it.
The PR here is blocking a thread for non persistent, which I -1000 about it.
This should really either setAutoRead (false) from Netty, or stop sending
confirmation back to clients..
Also there's an issue that I see that if a producer is blocked for a long
time connections will drop for TTL. So there should be some check for pending
requests and ignore TTL checks on that case.
> Fix OpenWire ProducerFlowControlTest Regression
> -----------------------------------------------
>
> Key: ARTEMIS-883
> URL: https://issues.apache.org/jira/browse/ARTEMIS-883
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: OpenWire
> Affects Versions: 1.5.1
> Reporter: Howard Gao
> Assignee: Howard Gao
> Fix For: 1.5.next
>
>
> ProducerFlowControlTest fails due to regression
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
