[
https://issues.apache.org/jira/browse/ARTEMIS-562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15815236#comment-15815236
]
ASF GitHub Bot commented on ARTEMIS-562:
----------------------------------------
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/955#discussion_r95383350
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallback.java
---
@@ -429,6 +442,12 @@ public void offerProducerCredit(final String address,
final int threshold,
final Receiver receiver) {
try {
+ // TODO - Do something smart here with the paging bits to figure
out the credit can be sent.
--- End diff --
I don't think there's anything to be done with paging. If this is an
anonymous producer, there's nothing to be done with paging...
Either this is the proper implementation, hence you would need to remove
the TODO, or this is something else broken.
I believe you should just remove the TODO here
> Use 'to' field if sender target is null
> ---------------------------------------
>
> Key: ARTEMIS-562
> URL: https://issues.apache.org/jira/browse/ARTEMIS-562
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: AMQP, Broker
> Affects Versions: 1.3.0
> Reporter: Gordon Sim
> Assignee: Howard Gao
> Attachments: anonymous-relay.patch, anonymous_sender.py
>
>
> ActiveMQ5 (and other AMQP brokers) support creating a sender with a null
> target, and then identifying the destination of each messages via the 'to'
> field. This is very useful in some request-response cases, as it avoids the
> 'service' having to create and manage senders for every reply-to address.
> Indeed the qpid-proton request-response examples rely on this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
