[
https://issues.apache.org/jira/browse/ARTEMIS-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15818698#comment-15818698
]
ASF GitHub Bot commented on ARTEMIS-915:
----------------------------------------
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/956#discussion_r95607988
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/core/server/ShutdownAwareComponent.java
---
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.core.server;
+
+/**
+ * A Component that needs to know the stop reason.
+ */
+public interface ShutdownAwareComponent extends ActiveMQComponent {
--- End diff --
I really don't like that name...
What about calling it ServiceComponent
make the method to be called stop(boolean isShutdown)
No need for these integers, and in case you want to keep a parameter,
please use an enumeration.
> WebComponent stopped when backup failback
> -----------------------------------------
>
> Key: ARTEMIS-915
> URL: https://issues.apache.org/jira/browse/ARTEMIS-915
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 1.5.1
> Reporter: Howard Gao
> Assignee: Howard Gao
> Fix For: 1.5.next
>
>
> In a fail-back scenario, if live is shut down and restart again, the backup
> will stop itself, and so will its webcomponent, which is a web server
> embedded. In that case user will not be able to access the backup via the web
> interface.
> So no matter whether the backup server is becoming live or fail back, the web
> component should be available all the time, until the VM is shutdown.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
