[
https://issues.apache.org/jira/browse/ARTEMIS-922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847482#comment-15847482
]
ASF GitHub Bot commented on ARTEMIS-922:
----------------------------------------
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/982#discussion_r98766262
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/addressing/AddressingTest.java
---
@@ -224,37 +224,30 @@ public void testMulticastRoutingBackwardsCompat()
throws Exception {
@Test
public void testPurgeOnNoConsumersTrue() throws Exception {
-
SimpleString address = new SimpleString("test.address");
SimpleString queueName =
SimpleString.toSimpleString(UUID.randomUUID().toString());
- // For each address, create 2 Queues with the same address, assert
both queues receive message
- boolean purgeOnNoConsumers = true;
- Queue q1 = server.createQueue(address, RoutingType.MULTICAST,
queueName, null, true, false, Queue.MAX_CONSUMERS_UNLIMITED,
purgeOnNoConsumers, true);
-
+ server.createQueue(address, RoutingType.ANYCAST, queueName, null,
null, true, false, false, false, false, 1, true, true);
+ assertNotNull(server.locateQueue(queueName));
ClientSession session = sessionFactory.createSession();
- session.start();
-
- ClientConsumer consumer1 = session.createConsumer(q1.getName());
- consumer1.close();
-
- assertFalse(server.queueQuery(queueName).isExists());
+ ClientProducer producer = session.createProducer(address);
+ producer.send(session.createMessage(true));
+ session.createConsumer(queueName).close();
--- End diff --
Just looking if you need a Wait for eventual failures.. that's all.
if you say no, I will merge it.
> Clean up addressing API
> -----------------------
>
> Key: ARTEMIS-922
> URL: https://issues.apache.org/jira/browse/ARTEMIS-922
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Fix For: 2.0.0
>
>
> A lot of new methods were added to the broker related to the addressing
> updates. Older, deprecated methods should no longer be used within the
> code-base (e.g. in tests) and some new methods can be
> simplified/consolidated. Some methods can be renamed to be more clear.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
